Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/ens: actually resolve ens names instead of returning owner #192

Merged
merged 9 commits into from
Dec 29, 2022

Conversation

q9f
Copy link
Owner

@q9f q9f commented Dec 28, 2022

ens resolver only returned the owner, this does look up the resolver and resolves the ens record

infura = Eth::Client.create("https://mainnet.infura.io/v3/#{ENV['INFURA_TOKEN']}")
# => #<Eth::Client::Http:0x00005614b684fd70
infura.resolve_ens "ncwc6edqldzy6mlo.eth"
# => "0xde270e46d63b1816d1b798cff473c4ba238aca73"

@q9f q9f added the bug Something isn't working label Dec 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2022

Codecov Report

Merging #192 (0b57a71) into main (d9fda51) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #192   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          70       74    +4     
  Lines        4253     4321   +68     
=======================================
+ Hits         4243     4311   +68     
  Misses         10       10           
Impacted Files Coverage Δ
lib/eth.rb 100.00% <100.00%> (ø)
lib/eth/client.rb 100.00% <100.00%> (ø)
lib/eth/ens.rb 100.00% <100.00%> (ø)
lib/eth/ens/coin_type.rb 100.00% <100.00%> (ø)
lib/eth/ens/resolver.rb 100.00% <100.00%> (ø)
spec/eth/client_spec.rb 100.00% <100.00%> (ø)
spec/eth/ens/coin_type_spec.rb 100.00% <100.00%> (ø)
spec/eth/ens/resolver_spec.rb 100.00% <100.00%> (ø)
spec/eth/ens_spec.rb 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@q9f q9f merged commit cb79fcb into main Dec 29, 2022
@q9f q9f deleted the q9f/ens/resolver branch December 29, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants