Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually overwrite solc path #212

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Manually overwrite solc path #212

merged 1 commit into from
Jan 27, 2023

Conversation

randoum
Copy link
Contributor

@randoum randoum commented Jan 27, 2023

Allow to manually set the solc path : Eth::Solidity.new('/blah/solc')

This does not change the default behavior to get the solc bin from the paths

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2023

Codecov Report

Merging #212 (d999d3d) into main (59bacd6) will decrease coverage by 0.26%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
- Coverage   99.77%   99.51%   -0.26%     
==========================================
  Files          77       77              
  Lines        4373     4373              
==========================================
- Hits         4363     4352      -11     
- Misses         10       21      +11     
Impacted Files Coverage Δ
lib/eth/solidity.rb 100.00% <100.00%> (ø)
spec/eth/ens/resolver_spec.rb 83.78% <0.00%> (-16.22%) ⬇️
lib/eth/ens/resolver.rb 85.29% <0.00%> (-14.71%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@q9f q9f merged commit 95312a1 into q9f:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants