Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual default_account #215

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Manual default_account #215

merged 1 commit into from
Feb 6, 2023

Conversation

randoum
Copy link
Contributor

@randoum randoum commented Feb 4, 2023

For remote connection, there is no Client.default_account that can be automatically set. However, we are able to define it manually through Client.default_account=. This removed the error message and allow calling Client.default_account after it was manually set

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2023

Codecov Report

Merging #215 (c1296a4) into main (a6fa05a) will decrease coverage by 0.26%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
- Coverage   99.77%   99.51%   -0.26%     
==========================================
  Files          77       77              
  Lines        4374     4374              
==========================================
- Hits         4364     4353      -11     
- Misses         10       21      +11     
Impacted Files Coverage Δ
lib/eth/client.rb 100.00% <100.00%> (ø)
spec/eth/ens/resolver_spec.rb 83.78% <0.00%> (-16.22%) ⬇️
lib/eth/ens/resolver.rb 85.29% <0.00%> (-14.71%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@q9f q9f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense :)

@q9f q9f added the bug Something isn't working label Feb 6, 2023
@q9f q9f merged commit f6f1c7d into q9f:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants