Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/api: remove coinbase as default account #269

Merged
merged 5 commits into from
Jun 23, 2024
Merged

eth/api: remove coinbase as default account #269

merged 5 commits into from
Jun 23, 2024

Conversation

q9f
Copy link
Owner

@q9f q9f commented Apr 16, 2024

the api will be removed in geth 1.14.x

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.70%. Comparing base (b437f59) to head (028d980).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
+ Coverage   95.84%   99.70%   +3.86%     
==========================================
  Files          77       77              
  Lines        4477     4477              
==========================================
+ Hits         4291     4464     +173     
+ Misses        186       13     -173     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@q9f q9f merged commit 91693b1 into main Jun 23, 2024
8 checks passed
@q9f q9f deleted the q9/client/coinbase branch June 23, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants