Adds support to check for the ethereum "null/zero address" #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Many dreams have gone to the null address to die, this provides a simple check for developers to opt in to avoiding that fate.
mattrasband
commented
Dec 7, 2024
| @@ -125,6 +123,28 @@ | |||
| end | |||
| end | |||
|
|
|||
| describe ".null?" do | |||
There was a problem hiding this comment.
Maybe another good name or alias would be .zero?. I figure .null? is safer since we use nil in ruby instead.
mattrasband
changed the title
q9f
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many ETH address validators specifically reject the null address to avoid potentially allowing unexpected behavior, but I didn't change any defaults to how this library functions.