eth/contract: allow creating from file, abi, bin #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #83 +/- ##
=======================================
Coverage 99.73% 99.73%
=======================================
Files 67 67
Lines 3780 3802 +22
=======================================
+ Hits 3770 3792 +22
Misses 10 10
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
kurotaky
reviewed
May 9, 2022
kurotaky
reviewed
May 9, 2022
Co-authored-by: Yuta Kurotaki <yuta.kurotaki@gmail.com>
Co-authored-by: Yuta Kurotaki <yuta.kurotaki@gmail.com>
|
Ok, this works now. |
mculp
reviewed
May 11, 2022
Co-authored-by: Matt Culpepper <mculp@users.noreply.github.com>
Co-authored-by: Matt Culpepper <mculp@users.noreply.github.com>
|
Thank you @mculp - I applied all your suggestions! |
|
👍 |
q9f
added
enhancement
mculp
added a commit
to mculp/eth.rb
that referenced
this pull request
Aug 1, 2022
* eth/contract: allow creating from file, abi, bin * eth/client: refactor contract code * Update lib/eth/contract.rb Co-authored-by: Yuta Kurotaki <yuta.kurotaki@gmail.com> * Update lib/eth/contract.rb Co-authored-by: Yuta Kurotaki <yuta.kurotaki@gmail.com> * spec: deploy ens and call it * spec: fix client spec for eip 1271 * docs: fix readme for contracts * docs: fix readme for contracts * spec: fix jsonrpc error code * spec: fix coverage * spec: fix coverage * eth/contract: apply @mculp's suggestions Co-authored-by: Matt Culpepper <mculp@users.noreply.github.com> * eth/contract: apply @mculp's suggestions Co-authored-by: Matt Culpepper <mculp@users.noreply.github.com> Co-authored-by: Yuta Kurotaki <yuta.kurotaki@gmail.com> Co-authored-by: Matt Culpepper <mculp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of
Contract.create:Contract.from_file(file: file)Contract.from_bin(name: name, abi: abi, bin: bin)Contract.from_abi(name: name, abi: abi, address: addr)