Skip to content
This repository has been archived by the owner on Feb 12, 2023. It is now read-only.

qTox prevents logout on GNOME 3 #1485

Closed
jurf opened this issue Mar 28, 2015 · 2 comments · Fixed by #3687
Closed

qTox prevents logout on GNOME 3 #1485

jurf opened this issue Mar 28, 2015 · 2 comments · Fixed by #3687
Labels
C-bug The issue contains a bug report OS-linux P-medium

Comments

@jurf
Copy link

jurf commented Mar 28, 2015

GNOME 3.16, Arch Linux. Same happened on 3.14.

When I try to logout while qTox is open in the background, nothing happens, until I close qTox. Extremely confusing, took me about a month to figure out what's wrong.
@dubslow dubslow added the C-bug The issue contains a bug report label Mar 28, 2015
@agilob agilob mentioned this issue May 15, 2015
Closed
@Talkless
Copy link
Contributor

Same in KDE (Kubuntu 14.04), I get system notification Logout canceled "/usr/bin/qtox" (or something like that, actually in my native language).

@agilob
Copy link
Contributor

agilob commented Sep 16, 2015

https://trac.transmissionbt.com/attachment/ticket/5206/0001-fix-Qt-tray-icon-causes-logout-cancelled-by-transmis.patch

seems to be related, also prevents on KDE5

apparently this code from widget.cpp can be problematic

void Widget::closeEvent(QCloseEvent *event)
{
    if (Settings::getInstance().getShowSystemTray() && Settings::getInstance().getCloseToTray() == true)
    {
        event->ignore();

@agilob agilob mentioned this issue Oct 6, 2015
Closed
Talkless added a commit to Talkless/qTox that referenced this issue Sep 4, 2016
@Talkless
fix(widget): do not block logout on Linux desktop environments
4c96cee 
Change closeEvent() to hideEvent() for handling main window closing.
Close event is no longer ignored, which prevented logging out from
various Linux desktop environments.

Closes qTox#1485
Talkless added a commit to Talkless/qTox that referenced this issue Sep 4, 2016
@Talkless
fix(widget): do not block logout on Linux desktop environments
7ee883b 
Change closeEvent() to hideEvent() for handling main window closing.
Close event is no longer ignored, which prevented logging out from
various Linux desktop environments.

Closes qTox#1485
@Talkless Talkless mentioned this issue Sep 4, 2016
Merged
Talkless added a commit to Talkless/qTox that referenced this issue Sep 10, 2016
@Talkless
fix(widget): do not block logout on Linux desktop environments (take …
5623398 
…two)

Revert commit 191fc15 to use closeEvent()
but without QEvent::ignore() which blocked logout on various Linux desktops,
and without redundant hide(). Since qApp->setQuitOnLastWindowClosed(false)
is used, and Qt::WA_DeleteOnClose is *NOT* used, default closeEvent() handling
is enought for implementing close-to-systray feature.

Improves fix for qTox#1485 and closes qTox#3699
Talkless added a commit to Talkless/qTox that referenced this issue Sep 10, 2016
@Talkless
fix(widget): do not block logout on Linux desktop environments v2
d5e467d 
Revert commit 191fc15 to use closeEvent()
but without QEvent::ignore() which blocked logout on various Linux desktops,
and without redundant hide(). Since qApp->setQuitOnLastWindowClosed(false)
is used, and Qt::WA_DeleteOnClose is *NOT* used, default closeEvent() handling
is enought for implementing close-to-systray feature.

Improves fix for qTox#1485 and closes qTox#3699
Talkless added a commit to Talkless/qTox that referenced this issue Sep 10, 2016
@Talkless
fix(widget): do not block logout on Linux desktop environments v2
78b0a15 
Revert commit 191fc15 to use closeEvent()
but without QEvent::ignore() which blocked logout on various Linux desktops,
and without redundant hide(). Using previous fix with hideEvent() produced
regresions because hide() is used in various places, which produced closing
behaviour.

Since qApp->setQuitOnLastWindowClosed(false) is used, and
Qt::WA_DeleteOnClose is *NOT* used, default closeEvent() handling is enough
for implementing close-to-systray feature.

Improves fix for qTox#1485 and closes qTox#3699
Talkless added a commit to Talkless/qTox that referenced this issue Sep 10, 2016
@Talkless
fix(widget): do not block logout on Linux desktop environments v2
6b00779 
Revert commit 191fc15 to use closeEvent()
but without QEvent::ignore() which blocked logout on various Linux desktops,
and without redundant hide(). Previous fix with hideEvent() produced
regressions because hide() is used in various places, which produced closing
behavior.

Since qApp->setQuitOnLastWindowClosed(false) is used, and
Qt::WA_DeleteOnClose is *NOT* used, default closeEvent() handling is enough
for implementing close-to-systray feature.

Improves fix for qTox#1485 and closes qTox#3699
@Talkless Talkless mentioned this issue Sep 10, 2016
Merged
@Talkless Talkless mentioned this issue Oct 13, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
C-bug The issue contains a bug report OS-linux P-medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(widget): do not block logout on Linux desktop environments Talkless/qTox
5 participants
@Talkless @agilob @zetok @dubslow @jurf