Merge pull request #29 from mxschmitt/patch-2

fix: Compatibility with QuickTime Player on macOS
qawolf · May 31, 2020 · d2533c6 · d2533c6
2 parents 2ecc52b + 7601e98
commit d2533c6
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "author": "QA Wolf",
   "name": "playwright-video",
-  "license": "BSD-3.0",
+  "license": "BSD-3-Clause-Clear",
   "version": "1.0.2",
   "description": "Capture a video of a Playwright page",
   "main": "./build/index.js",

diff --git a/src/VideoWriter.ts b/src/VideoWriter.ts
@@ -37,6 +37,7 @@ export class VideoWriter extends EventEmitter {
         .inputFormat('image2pipe')
         .inputFPS(this._framesPerSecond)
         .outputOptions('-preset ultrafast')
+        .outputOptions('-pix_fmt yuv420p')
         .on('error', (e) => {
           this.emit('ffmpegerror', e.message);
 

diff --git a/tests/VideoWriter.test.ts b/tests/VideoWriter.test.ts
@@ -22,7 +22,7 @@ describe('VideoWriter', () => {
     writer.write(
       // White 1×1 PNG http://proger.i-forge.net/%D0%9A%D0%BE%D0%BC%D0%BF%D1%8C%D1%8E%D1%82%D0%B5%D1%80/[20121112]%20The%20smallest%20transparent%20pixel.html
       Buffer.from(
-        'iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAAAAAA6fptVAAAACklEQVQYV2P4DwABAQEAWk1v8QAAAABJRU5ErkJggg==',
+        'iVBORw0KGgoAAAANSUhEUgAAAAYAAACiCAYAAABiQbywAAAAKklEQVRYhe3JMQEAAAjDMMC/52EAARzp2XSS1NFcEwAAAAAAAAAAAD9gARW/BUBIVRRtAAAAAElFTkSuQmCC',
         'base64',
       ),
     );

diff --git a/tests/saveVideo.test.ts b/tests/saveVideo.test.ts
@@ -4,6 +4,8 @@ import { join } from 'path';
 import { chromium, ChromiumBrowser } from 'playwright';
 import { saveVideo } from '../src/saveVideo';
 
+jest.setTimeout(10 * 1000)
+
 describe('saveVideo', () => {
   let browser: ChromiumBrowser;