This repository has been archived by the owner on Jul 2, 2021. It is now read-only.
Handle some more CDP errors #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On very fast machines, we may not have time to connect to a new tab and start recording before the tab is closed.
|
@jperl Thank you for the merge! Do you think you'd have time to put out a patch release sometime soon? |
|
Yes, sorry for the delay. Taking a long overdue vacation this week. Will release it first thing when we get back on Monday. |
|
That's good. It's been a weird year for vacations. Glad you're making it happen! |
|
@celeryclub Released in https://github.com/qawolf/playwright-video/releases/tag/v2.3.1 thanks for your patience 🙏 |
|
Thanks so much @jperl! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey team. Hope all is well.
I found a little issue with the multi-tab recording. On very fast machines, we may not have time to connect to a new tab and start recording before the tab is closed. This PR handles failures that sometimes happen when in this scenario.
Thank you!