Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remove key on vehicle stored) #369

Closed
wants to merge 1 commit into from

Conversation

MrNewb
Copy link

@MrNewb MrNewb commented Dec 20, 2024

Describe Pull request
I noticed the event exists but is not being used. It doesn't update on the server side, so based on some other client-side events, I assume this is the intended method of use?

If your PR is to fix an issue mention that issue here
This isn't exactly a fix, but it makes use of some lesser-known recipe features from qb-core. It also allows third-party key systems to attach to an event for qb-garages, further enhancing the user experience.

Since this isn't updating the server-side table, I'm unsure if it fully aligns with the guidelines. Additionally, certain qb-vehiclekeys grant events on the client side also fail to update the server-side table, leading to inconsistency in the preferred method for granting/removing.

I'm happy to make adjustments; I just wanted to understand the plan for these events.

Questions (please complete the following information):

  • Have you personally loaded this code into an updated qbcore project and checked all it's functionality? [yes]
  • Does your code fit the style guidelines? [yes]
  • Does your PR fit the contribution guidelines? [idk]

Noticed the event exists but is unused. It does not update serverside, based on some of the other client side events I assume thats the intended use method?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant