Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebUI: filter counters are not updated when deleting a torrent that is currently filtered out #21070

Closed
cascandaliato opened this issue Jul 14, 2024 · 0 comments · Fixed by #21071
Closed

WebUI: filter counters are not updated when deleting a torrent that is currently filtered out #21070

cascandaliato opened this issue Jul 14, 2024 · 0 comments · Fixed by #21071
Labels
WebUI WebUI-related issues/changes

Comments

@cascandaliato
Copy link
Contributor

qBittorrent & operating system versions

qBittorrent: 4.6.5 x64 (https://github.com/userdocs/qbittorrent-nox-static/releases/tag/release-4.6.5_v2.0.10)
Operating system: Linux 6.9.7-1-default
Qt: 6.7.2
libtorrent-rasterbar: 2.0.10

What is the problem?

Torrents that are deleted while they are filtered out by the Web UI are not removed from the torrents list and the corresponding filter counters are not updated.

Steps to reproduce

  1. Open the Web UI.
  2. Add a new torrent that is guaranteed to go to Stalled Downloading (I created one using https://kimbatt.github.io/torrent-creator/). The counter for Stalled Downloading will be increased by 1.
  3. Select the Active filter.
  4. Call the web API to delete the torrent.
  5. The counter for Stalled Downloading will stay unchanged, and if you select the All filter, the torrent will still be in the torrents list.

Additional context

No response

Log(s) & preferences file(s)

No response
@cascandaliato cascandaliato mentioned this issue Jul 14, 2024
Merged
@xavier2k6 xavier2k6 added the WebUI WebUI-related issues/changes label Jul 15, 2024
Chocobo1 pushed a commit that referenced this issue Jul 29, 2024
@cascandaliato
WebUI: remove deleted torrents even if they are currently filtered out
642a9c2 
Remove the torrent row regardless of it being visible.

I've also removed the return value because:
* it doesn't appear to be used by any caller;
* other functions (e.g. updateRowData) do not return any value;
* it's not clear whether true refers to the torrent being removed from the list of all torrents or just the visible ones.

Closes #21070.
PR #21071.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
WebUI WebUI-related issues/changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WebUI: remove deleted torrents even if they are currently filtered out cascandaliato/qBittorrent
2 participants
@cascandaliato @xavier2k6