Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebUI: remove deleted torrents even if they are currently filtered out #21071

Merged
merged 1 commit into from
Jul 29, 2024
Merged

WebUI: remove deleted torrents even if they are currently filtered out #21071

merged 1 commit into from
Jul 29, 2024

Conversation

cascandaliato
Copy link
Contributor

Remove the torrent row regardless of it being visible.

I've also removed the return value because:

  • it doesn't appear to be used by any caller;
  • other functions (e.g. updateRowData) do not return any value;
  • it's not clear whether true refers to the torrent being removed from the list of all torrents or just the visible ones.

Closes #21070.

@thalieht thalieht added the WebUI WebUI-related issues/changes label Jul 14, 2024
@glassez glassez requested a review from a team July 15, 2024 03:29
@Chocobo1 Chocobo1 requested a review from a team July 26, 2024 13:37
@Chocobo1 Chocobo1 added this to the 5.1 milestone Jul 29, 2024
@Chocobo1 Chocobo1 merged commit 642a9c2 into qbittorrent:master Jul 29, 2024
14 checks passed
@Chocobo1
Copy link
Member

@cascandaliato
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chocobo1 Chocobo1 Chocobo1 approved these changes

Assignees
No one assigned
Labels
WebUI WebUI-related issues/changes
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

WebUI: filter counters are not updated when deleting a torrent that is currently filtered out
3 participants
@cascandaliato @Chocobo1 @thalieht