Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change stalled and paused colours #6174

Closed
magao opened this issue Dec 31, 2016 · 4 comments
Closed

change stalled and paused colours #6174

magao opened this issue Dec 31, 2016 · 4 comments
Labels
Feature request Look and feel Affect UI "Look and feel" only without changing the logic

Comments

@magao
Copy link
Contributor

magao commented Dec 31, 2016 •
edited by xavier2k6
Loading

Currently stalled is displayed as dark grey (or black), and paused is salmon (reddish, which normally indicates something undesireable). Stalled is an undesirable condition, while paused is deliberate, so these choices seem reversed to how they should be.

I will submit a pull request which changes paused to use dark grey (or black with dark theme), and stalled to use maroon (which I find better for reading than salmon).
@magao
Copy link
Contributor Author

magao commented Jan 1, 2017

Actually, maroon might not work as well for dark theme, so I'll make stalled salmon with a dark theme.

@magao magao mentioned this issue Jan 1, 2017
Closed
@okeatime
Copy link
Contributor

okeatime commented Jan 2, 2017

Please just make a PR without creating an issue.
You are flooding the issue tracker.
Thank you.

@magao
Copy link
Contributor Author

magao commented Jan 3, 2017

Sorry - I'm used to an environment where we create an issue for everything for tracking purposes.

magao added a commit to magao/qBittorrent that referenced this issue Feb 8, 2017
@magao
Change paused and stalled colours. Closes qbittorrent#6174.
058ecc1 
--HG--
branch : magao-dev
@magao magao mentioned this issue Feb 9, 2017
Closed
@sledgehammer999 sledgehammer999 changed the title Feature request: change stalled and paused colours change stalled and paused colours Oct 29, 2020
@thalieht thalieht added the Look and feel Affect UI "Look and feel" only without changing the logic label Aug 6, 2022
@xavier2k6
Copy link
Member

A variation of this was implemented in #15769 & will be included in 4.5.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature request Look and feel Affect UI "Look and feel" only without changing the logic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@magao @thalieht @FranciscoPombal @okeatime @xavier2k6