Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase WebUI window heights #11030

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Conversation

Piccirello
Copy link
Member

All windows should display their full content without a scroll bar, when possible. Using a max height of 600px to avoid unnecessarily tall windows.

Screen Shot 2019-08-06 at 1 43 24 AM
Screen Shot 2019-08-06 at 1 43 37 AM

Using a max height of 600px to avoid unnecessarily tall windows.
@Piccirello Piccirello added the WebUI WebUI-related issues/changes label Aug 6, 2019
@glassez
Copy link
Member

glassez commented Aug 6, 2019

@Piccirello, please stop create branches in this repo!

@glassez
Copy link
Member

glassez commented Aug 6, 2019

Displays of some devices still have not enough resolution to fit 600px-height windows.

@lnicola
Copy link

lnicola commented Aug 6, 2019

Can you use 60% instead of a pixel height?

@Piccirello
Copy link
Member Author

@Piccirello, please stop create branches in this repo!

Shit, I pushed to the wrong remote. My bad.

Displays of some devices still have not enough resolution to fit 600px-height windows.

At some point we need to move the application forward, just like how we've dropped Windows XP support, < IE 11 support, etc. As a reference point, the's GUI Add New Torrent dialog uses a height of 620px.

Can you use 60% instead of a pixel height?

The ancient web UI library that we use doesn't support percentages.

@lnicola
Copy link

lnicola commented Aug 6, 2019

Maybe reduce the textarea height and.. I don't know. Take a look at the one from Transmission:

image

I can't really offer you a solution, but I didn't feel like I was missing anything when using that.

@Piccirello
Copy link
Member Author

Piccirello commented Aug 6, 2019

@lnicola Are you concerned that the window is too tall? Or just that the dialog is too cluttered?

@lnicola
Copy link

lnicola commented Aug 6, 2019

Apparently it's too tall to fit on the devices glassez is worried about. Reorganizing it a little or removing some of the options could be a solution, but I don't expect it to be too popular. I wouldn't mind having fewer options in there if it avoided the need to scroll.

@Piccirello
Copy link
Member Author

I don’t think the height will be an issue, but I could be wrong. One option is to put the change out there and see if any users report issues.

@Chocobo1
Copy link
Member

Chocobo1 commented Aug 7, 2019

IMO we hit the maximum limit for height, if we are going to add more controls to it we should really reorganize it (in a later PR), I mean the current layout doesn't make good use of the available screen width.

@Chocobo1 Chocobo1 merged commit f31bcc3 into master Aug 8, 2019
@Chocobo1
Copy link
Member

Chocobo1 commented Aug 8, 2019

@Piccirello
Thank you!

@Chocobo1 Chocobo1 deleted the webui-increase-window-height branch August 8, 2019 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants