-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase WebUI window heights #11030
Conversation
Using a max height of 600px to avoid unnecessarily tall windows.
@Piccirello, please stop create branches in this repo! |
Displays of some devices still have not enough resolution to fit 600px-height windows. |
Can you use 60% instead of a pixel height? |
Shit, I pushed to the wrong remote. My bad.
At some point we need to move the application forward, just like how we've dropped Windows XP support, < IE 11 support, etc. As a reference point, the's GUI Add New Torrent dialog uses a height of 620px.
The ancient web UI library that we use doesn't support percentages. |
@lnicola Are you concerned that the window is too tall? Or just that the dialog is too cluttered? |
Apparently it's too tall to fit on the devices glassez is worried about. Reorganizing it a little or removing some of the options could be a solution, but I don't expect it to be too popular. I wouldn't mind having fewer options in there if it avoided the need to scroll. |
I don’t think the height will be an issue, but I could be wrong. One option is to put the change out there and see if any users report issues. |
IMO we hit the maximum limit for height, if we are going to add more controls to it we should really reorganize it (in a later PR), I mean the current layout doesn't make good use of the available screen width. |
@Piccirello |
All windows should display their full content without a scroll bar, when possible. Using a max height of 600px to avoid unnecessarily tall windows.