Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use functions deprecated in Qt 5.15 #12969

Merged
merged 7 commits into from
Jun 6, 2020
Merged

Don't use functions deprecated in Qt 5.15 #12969

merged 7 commits into from
Jun 6, 2020

Conversation

Chocobo1
Copy link
Member

@Chocobo1 Chocobo1 commented Jun 4, 2020

  • Don't use deprecated QTextStreamFunctions::flush()
  • Don't use deprecated QSet::iterator::operator+(int)
  • Don't use deprecated QAbstractSocket::error()
  • Don't use QWheelEvent deprecated functions
  • Don't use deprecated QButtonGroup::buttonClicked()
  • Don't use deprecated QUrl::topLevelDomain()
  • Don't use deprecated QProcess::startDetached() overload

@Chocobo1 Chocobo1 added the Code cleanup Clean up the code while preserving the same outcome label Jun 4, 2020
@Chocobo1 Chocobo1 added this to the 4.2.6 milestone Jun 4, 2020
@Chocobo1
Don't use deprecated QTextStreamFunctions::flush()
c239568 
Qt doc states: "If QTextStream operates on a string, this function does
nothing". So remove it.
glassez
glassez reviewed Jun 4, 2020
View reviewed changes
src/base/algorithm.h Show resolved Hide resolved
src/app/application.cpp Outdated Show resolved Hide resolved
src/gui/properties/peerlistwidget.cpp Show resolved Hide resolved
@Chocobo1 Chocobo1 merged commit 7668d79 into qbittorrent:master Jun 6, 2020
@Chocobo1 Chocobo1 deleted the qt5 branch June 6, 2020 04:52
@Rootax Rootax mentioned this pull request Jun 6, 2020
Closed
@IceCodeNew IceCodeNew mentioned this pull request Aug 5, 2020
Closed
c0re100 pushed a commit to c0re100/qBittorrent-Enhanced-Edition that referenced this pull request Aug 5, 2020
@Chocobo1 @c0re100
Merge pull request qbittorrent#12969 from Chocobo1/qt5
bf3f782 
Don't use functions deprecated in Qt 5.15
IceCodeNew pushed a commit to IceCodeNew/qBittorrent-Enhanced-Edition that referenced this pull request Aug 28, 2020
@Chocobo1 @IceCodeNew
Merge pull request qbittorrent#12969 from Chocobo1/qt5
8e28009 
Don't use functions deprecated in Qt 5.15
@tearfur tearfur mentioned this pull request Jun 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glassez glassez glassez approved these changes

Assignees
No one assigned
Labels
Code cleanup Clean up the code while preserving the same outcome
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Chocobo1 @glassez