Fix received metadata handling #13905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glassez
requested review from
sledgehammer999,
a team and
Chocobo1
and removed request for
sledgehammer999
|
No problems detected with any combination of "Keep top-level folder", .!qB, temp folder. |
Chocobo1
reviewed
Dec 5, 2020
glassez
force-pushed
the
handle-metadata
branch
from
ce80796 to
4e04cd2
Compare
Chocobo1
approved these changes
Dec 6, 2020
IceCodeNew
pushed a commit
to IceCodeNew/qBittorrent-Enhanced-Edition
that referenced
this pull request
Dec 7, 2020
Fix received metadata handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reincarnation of the last attempt to fix/improve received metadata handling (#13736).
Now torrent is reloaded internally once metadata is received to correctly apply all needed logic of preprocessing torrent content and finding probably existing files left from previous incomplete download.
Right now, detecting existing files should work the same regardless of how the torrent is added (using .torrent file or Magnet link).
Also, the implemented mechanisms should serve as a basis for future improvements in other aspects (for example, resuming "Missing files" torrent downloads without rechecking).