Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the correct type when referring to info hash #13912

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Use the correct type when referring to info hash #13912

merged 1 commit into from
Dec 8, 2020

Conversation

Chocobo1
Copy link
Member

@Chocobo1 Chocobo1 commented Dec 5, 2020 •
edited
Loading

This is a prerequisite clean up before further transition into new v2 info hash.

For testers:
It is not expected that this PR will break any existing use case. Please look for regressions in tracker filters widgets.

@Chocobo1 Chocobo1 added Core Code cleanup Clean up the code while preserving the same outcome labels Dec 5, 2020
@Chocobo1 Chocobo1 added this to the 4.3.2 milestone Dec 5, 2020
@FranciscoPombal
Copy link
Member

@Chocobo1

Please look for regressions in tracker filters widgets.

image

This is what you mean, right? Anything specific you'd think would be a problem? I should be able to look into it soon.

@Chocobo1
Copy link
Member Author

Chocobo1 commented Dec 6, 2020

This is what you mean, right? Anything specific you'd think would be a problem?

Yes. Nothing really specific, the usual bugs (crashes, unexpected behaviors) might creep in.

@Chocobo1 Chocobo1 force-pushed the infohash branch 2 times, most recently from f8386a8 to 621591e Compare December 6, 2020 06:00
@thalieht
Copy link
Contributor

thalieht commented Dec 6, 2020

Error filter is always 0 even when no tracker is working. Can't test Warning because i'm not getting any.
I have both "Always announce...." in adv options enabled.

@Chocobo1
Copy link
Member Author

Chocobo1 commented Dec 6, 2020

Error filter is always 0 even when no tracker is working. Can't test Warning because i'm not getting any.

Thank you, should be fixed now.

glassez
glassez approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@glassez glassez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Please wait for testing reports.

@FranciscoPombal
Copy link
Member

If there is any regression, I can't find it 👍. Tested on both Windows 10 and Ubuntu 18.04, libtorrent 1.2.11 in both cases.

thalieht
thalieht approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@thalieht thalieht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find any problems either.

@Chocobo1 Chocobo1 merged commit d484c0e into qbittorrent:master Dec 8, 2020
@Chocobo1 Chocobo1 deleted the infohash branch December 8, 2020 12:53
@Chocobo1
Copy link
Member Author

Chocobo1 commented Dec 8, 2020

Thanks everyone!

IceCodeNew pushed a commit to IceCodeNew/qBittorrent-Enhanced-Edition that referenced this pull request Dec 8, 2020
@Chocobo1
Merge pull request qbittorrent#13912 from Chocobo1/infohash
55f5b1d 
Use the correct type when referring to info hash
@tearfur tearfur mentioned this pull request Jun 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FranciscoPombal FranciscoPombal FranciscoPombal approved these changes

@thalieht thalieht thalieht approved these changes

@glassez glassez glassez approved these changes

Assignees
No one assigned
Labels
Code cleanup Clean up the code while preserving the same outcome Core
Projects
None yet
Milestone
4.3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Chocobo1 @FranciscoPombal @thalieht @glassez