Use an appropriate method to show modal dialog #16809
Conversation
| @@ -353,7 +352,7 @@ void TransferListWidget::setSelectedTorrentsLocation() | |||
| } | |||
| }); | |||
|
|
|||
| fileDialog->show(); | |||
| fileDialog->open(); | |||
There was a problem hiding this comment.
I think this would be the correct usage pattern regardless of fixing anything.
There is another instance of this at MainWindow::askRecursiveTorrentDownloadConfirmation(): confirmBox->show(); would you mind change it too?
There was a problem hiding this comment.
I think this would be the correct usage pattern regardless if it fixes anything.
👍
There is another instance of this at
MainWindow::askRecursiveTorrentDownloadConfirmation():confirmBox->show();would you mind change it too?
I will do it as soon as the next window of free time appears.
There was a problem hiding this comment.
I will do it as soon as the next window of free time appears.
Done.
There was a problem hiding this comment.
Now clicking Set location... from the context menu on a torrent does open a file dialog on macOS without making the mainwindow unresponsive to user input (after the dialog is closed).
Also I can't reproduce the crash on Win 10 mentioned with steps in #15779 (comment)
That "crash" was fixed via linked PR #16158 |
I know. I am just making sure that it didn't resurface with this PR. |
No description provided.