Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hostname instead of domain name in tracker filter list #19062

Merged
merged 8 commits into from
Jun 5, 2023
Merged

Use hostname instead of domain name in tracker filter list #19062

merged 8 commits into from
Jun 5, 2023

Conversation

tearfur
Copy link
Contributor

@tearfur tearfur commented Jun 2, 2023 •
edited
Loading

A follow up of #18190 (comment). Closes #19035.

QT6 UI

Before After
image image

WebUI

Before After
image image

@tearfur tearfur mentioned this pull request Jun 2, 2023
Merged
@ttys3 ttys3 mentioned this pull request Jun 2, 2023
Closed
@tearfur tearfur marked this pull request as ready for review June 2, 2023 16:49
@tearfur @Chocobo1
quite the oversight that was
82a139f 
Co-authored-by: Chocobo1 <Chocobo1@users.noreply.github.com>
glassez
glassez previously approved these changes Jun 3, 2023
View reviewed changes
@glassez glassez added WebUI WebUI-related issues/changes GUI GUI-related issues/changes labels Jun 3, 2023
@glassez glassez added this to the 4.6.0 milestone Jun 3, 2023
@tearfur
Merge branch 'master' into use-hostname
ab6a2aa 
# Conflicts:
#	src/webui/www/private/scripts/client.js
@glassez glassez merged commit 2e87e6e into qbittorrent:master Jun 5, 2023
@glassez
Copy link
Member

glassez commented Jun 5, 2023

@tearfur
Thank you!

@tearfur tearfur deleted the use-hostname branch June 5, 2023 13:01
This was referenced Jul 12, 2023
Closed
Merged
glassez added a commit that referenced this pull request Jul 17, 2023
@glassez
Use previous approach of deducing favicon URL
57085ca 
PR #19325.
Fixes regression of #19062.
Closes #19307.
@Pentaphon
Copy link

Pentaphon commented Aug 19, 2023 •
edited
Loading

I feel like this makes the tracker filter list harder to read by adding more of the announce URL that isn't necessary and just makes the URLs longer in the filter list. The only necessary descriptive prefixes are ipv6 such as in your before and after example.

@tearfur Can you make it so qBittorrent ignores common, useless prefixes of tracker domains? Such as:

tracker
t for tracker
tr for tracker
tk for tracker
bt for BitTorrent
torrent which is obvious
bttracker for BitTorrent tracker
opentracker for URLs using that software
open for a shortened version of the above.

@terrytw terrytw mentioned this pull request Nov 30, 2023
Closed
@terrytw terrytw mentioned this pull request Apr 8, 2024
Merged
@terrytw terrytw mentioned this pull request Sep 30, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chocobo1 Chocobo1 Chocobo1 approved these changes

@thalieht thalieht thalieht approved these changes

@glassez glassez glassez approved these changes

Assignees
No one assigned
Labels
GUI GUI-related issues/changes WebUI WebUI-related issues/changes
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

Qt GUI tracklist filter widget may display wrong top-level domain for tlds like .co.uk
5 participants
@tearfur @glassez @Pentaphon @thalieht @Chocobo1