-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply filename filter to subfolder names as well #20902
Conversation
How do i test/use this? |
You can follow #14480 (comment) (I haven't tested it myself yet.) |
Doesn't work. |
Could you test it now? There are pitfalls in how Qt interprets wildcards. |
Any chance the root folder will be excluded? It seems like a bug if any pattern matches it and ends up deselecting everything. |
I think I could take care of that. But does it make sense? Note that there are several other similar cases:
What do you think we should do there? |
This comment was marked as outdated.
This comment was marked as outdated.
Should also be excluded IMO.
User should re-evaluate his patterns / works as advertised. |
It turned out that it was easier and more reliable to cover all such cases at once. |
That doesn't seem right. I was about to report that it doesn't work at all because a pattern matched the root folder until i read this. I'm sure i'm not the only one who will consider this a bug. |
Unfortunately, I have to admit that I don't understand exactly what you mean. Could you describe how you think it should behave in the above cases, when all files are excluded by the filter? Don't we have only two ways, i.e. either accept it (add a torrent with all the files excluded), or reject it (don't apply a filter for this torrent)? We can only report something in addition to one of these reactions. |
Reverted the last commit. |
I don't know how things work on the code level. i was thinking in terms of "don't apply any pattern on the root folder (is it an item?) and if there is only 1 file in the torrent but apply the patterns to everything else" e.g. patterns:
It would filter everything except the "text.txt" file. I mean it would make no sense to ignore all patterns because one of them matched the root folder i.e. ignore *.jpg in the example.
I don't understand what that means. |
I don't ask about the code.
It makes sense, at least to me. But I can't imagine the possible expectations of other users from this feature. For example, if torrents are added automatically, how likely is it that the user does not want to download certain types of files anyway, even if some torrents do not contain anything else? |
Good point, i forgot about that. |
there are fixes for gtk3 theme glitching in 6.5 series however they are behind LTS but are also available in 6.6/6.7 series, we also know that some other issues as noted via CI Qt changing that are fixed with later revisions of Qt 6.6/6.7 Series The next Qt LTS will be 6.8 due around Sept. '24. |
In any case, it should be borne in mind that these are different ways, and I do not know which one would be preferable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Closes #14480.