-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix highlighted piece color #20971
base: master
Are you sure you want to change the base?
Fix highlighted piece color #20971
Conversation
Haven't tested yet but how does this behave in light/dark "app" mode on Windows when "accent" color is changed? |
Piece colour is always based on the highlight color of QPalatte, which is always constant on Windows and not related to accent. I prefer we keep the scope limited to largest use case i.e default settings, you can't test or make this work on all colors. The attached screenshot in PR description is with default light/dark mode on Windows. |
Not completely accurate anymore as of Qt 6.5+ "dark mode"
https://www.qt.io/blog/dark-mode-on-windows-11-with-qt-6.5 That's why I asked, in any case - this PR does appear to enhance the contrast. |
|
@jagannatharjun |
Looks good for me 👍 |
7af3a8c
4cde4da
to
7af3a8c
Compare
rebased |
re-tested! 👍 |
Much better contrast with download piece and selected pieces. Previously same color was used for both
New Behaviour
capture-2024-06-18.11-02PM.mp4
capture-2024-06-18.11-08PM.mp4