Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI: Support managing web seeds #21055

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Piccirello
Copy link
Member

@Piccirello Piccirello commented Jul 11, 2024

Closes #8475.

Screenshot 2024-07-11 at 12 19 03
Screenshot 2024-07-11 at 12 19 10
Screenshot 2024-07-11 at 12 19 24

@Piccirello Piccirello added the WebUI WebUI-related issues/changes label Jul 11, 2024
src/webui/api/torrentscontroller.cpp Outdated Show resolved Hide resolved
src/webui/www/private/addwebseeds.html Outdated Show resolved Hide resolved
src/webui/www/private/editwebseed.html Outdated Show resolved Hide resolved
@Piccirello Piccirello force-pushed the webui-webseeds branch 2 times, most recently from 6eeda7d to 3eb4d0c Compare July 15, 2024 20:54
@Piccirello Piccirello requested a review from Chocobo1 July 15, 2024 20:55
src/webui/www/private/addwebseeds.html Outdated Show resolved Hide resolved
src/webui/www/private/addwebseeds.html Outdated Show resolved Hide resolved
src/webui/www/private/addwebseeds.html Outdated Show resolved Hide resolved
src/webui/www/private/editwebseed.html Outdated Show resolved Hide resolved
src/webui/www/private/editwebseed.html Outdated Show resolved Hide resolved
src/webui/www/private/editwebseed.html Outdated Show resolved Hide resolved
This makes it easier to add a context menu to rows.
The GUI referred to these items as both "web seeds" and "URL seeds". This also removes the arbitrary capitalization of "Web" and standardizes on the verb of "Add". Lastly, menu items that open a dialog now end with an ellipsis.
@Piccirello Piccirello marked this pull request as ready for review August 12, 2024 00:21
@Piccirello Piccirello requested a review from a team August 12, 2024 00:22
@glassez glassez changed the title Support managing web seeds from WebUI WebUI: Support managing web seeds Aug 13, 2024
Copy link
Member

@Chocobo1 Chocobo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be the last comment from me. Everything else looks good.

@@ -235,6 +235,12 @@ <h1 class="applicationTitle">qBittorrent Web User Interface <span class="version
<li><a href="#copyPeer" id="CopyPeerInfo"><img src="images/edit-copy.svg" alt="QBT_TR(Copy IP:port)QBT_TR[CONTEXT=PeerListWidget]"> QBT_TR(Copy IP:port)QBT_TR[CONTEXT=PeerListWidget]</a></li>
<li class="separator"><a href="#banPeer"><img src="images/peers-remove.svg" alt="QBT_TR(Ban peer permanently)QBT_TR[CONTEXT=PeerListWidget]"> QBT_TR(Ban peer permanently)QBT_TR[CONTEXT=PeerListWidget]</a></li>
</ul>
<ul id="torrentWebseedsMenu" class="contextMenu">
<li><a href="#AddWebSeeds"><img src="images/list-add.svg" alt="QBT_TR(Add web seeds...)QBT_TR[CONTEXT=HttpServer]"> QBT_TR(Add web seeds...)QBT_TR[CONTEXT=HttpServer]</a></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They should have the same context:

Suggested change
<li><a href="#AddWebSeeds"><img src="images/list-add.svg" alt="QBT_TR(Add web seeds...)QBT_TR[CONTEXT=HttpServer]"> QBT_TR(Add web seeds...)QBT_TR[CONTEXT=HttpServer]</a></li>
<li><a href="#AddWebSeeds"><img src="images/list-add.svg" alt="QBT_TR(Add web seeds...)QBT_TR[CONTEXT=HttpServer]"> QBT_TR(Add web seeds...)QBT_TR[CONTEXT=PropertiesWidget]</a></li>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Piccirello soft bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels