-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebUI: Support managing web seeds #21055
base: master
Are you sure you want to change the base?
Conversation
6eeda7d
to
3eb4d0c
Compare
7cd1dc1
to
75be788
Compare
63cd07f
to
cc50dc1
Compare
This makes it easier to add a context menu to rows.
The GUI referred to these items as both "web seeds" and "URL seeds". This also removes the arbitrary capitalization of "Web" and standardizes on the verb of "Add". Lastly, menu items that open a dialog now end with an ellipsis.
cc50dc1
to
fede19b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be the last comment from me. Everything else looks good.
@@ -235,6 +235,12 @@ <h1 class="applicationTitle">qBittorrent Web User Interface <span class="version | |||
<li><a href="#copyPeer" id="CopyPeerInfo"><img src="images/edit-copy.svg" alt="QBT_TR(Copy IP:port)QBT_TR[CONTEXT=PeerListWidget]"> QBT_TR(Copy IP:port)QBT_TR[CONTEXT=PeerListWidget]</a></li> | |||
<li class="separator"><a href="#banPeer"><img src="images/peers-remove.svg" alt="QBT_TR(Ban peer permanently)QBT_TR[CONTEXT=PeerListWidget]"> QBT_TR(Ban peer permanently)QBT_TR[CONTEXT=PeerListWidget]</a></li> | |||
</ul> | |||
<ul id="torrentWebseedsMenu" class="contextMenu"> | |||
<li><a href="#AddWebSeeds"><img src="images/list-add.svg" alt="QBT_TR(Add web seeds...)QBT_TR[CONTEXT=HttpServer]"> QBT_TR(Add web seeds...)QBT_TR[CONTEXT=HttpServer]</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They should have the same context:
<li><a href="#AddWebSeeds"><img src="images/list-add.svg" alt="QBT_TR(Add web seeds...)QBT_TR[CONTEXT=HttpServer]"> QBT_TR(Add web seeds...)QBT_TR[CONTEXT=HttpServer]</a></li> | |
<li><a href="#AddWebSeeds"><img src="images/list-add.svg" alt="QBT_TR(Add web seeds...)QBT_TR[CONTEXT=HttpServer]"> QBT_TR(Add web seeds...)QBT_TR[CONTEXT=PropertiesWidget]</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Piccirello soft bump
Closes #8475.