-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support removing tracker from all torrents in WebUI/WebAPI #21056
base: master
Are you sure you want to change the base?
Conversation
f00ad46
to
26c4e4d
Compare
a82d621
to
88c84be
Compare
88c84be
to
75905c6
Compare
@Chocobo1 just curious, why get this in 5.1 instead of 5.0? |
AFAIK v5.0 is in 'bug fix only' stage. New feature goes into the next dev cycle (v5.1). |
Is there somewhere I can follow along this discussion/decision making? |
It usually starts with a new git branch creation (v5.0) and backport PRs emerge. The core devs discuss about it internally. |
This should take effect with the release of RC. We were merging the "soft" features between beta and RC, and since RC is still not released, we could merge similar changes in 5.0. |
I don't really have strong reason or preference for it. By default I'm leaning to v5.1 for everything. |
This should have been included as part of qbittorrent#20601.
75905c6
to
7ba570e
Compare
7ba570e
to
87a9a47
Compare
87a9a47
to
59420a3
Compare
59420a3
to
016ff03
Compare
@Piccirello, could you also add this option? |
I'm going to hold off for now but good future work. |
|
||
const QStringList urls = params()[u"urls"_s].split(u'|'); | ||
torrent->removeTrackers(urls); | ||
for (BitTorrent::Torrent *const torrent : asConst(BitTorrent::Session::instance()->torrents())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for (BitTorrent::Torrent *const torrent : asConst(BitTorrent::Session::instance()->torrents())) | |
for (BitTorrent::Torrent *const torrent : asConst(torrents)) |
Closes #20661.