Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI: Support auto resizing table columns #21655

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

Piccirello
Copy link
Member

@Piccirello Piccirello commented Oct 20, 2024

Auto resize can be triggered by:

  1. Double clicking the column's resize handle (its rightmost edge)
  2. The table header's context menu

Screenshot 2024-10-24 at 14 21 02

Closes #21627.

@Piccirello Piccirello added the WebUI WebUI-related issues/changes label Oct 20, 2024
@Piccirello Piccirello added this to the 5.1 milestone Oct 20, 2024
Copy link
Member

@Chocobo1 Chocobo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In GUI we have "Resize columns" at the bottom of menu.
It will resize all enabled columns. Maybe you would like to match webui with it?

src/webui/www/private/scripts/dynamicTable.js Outdated Show resolved Hide resolved
src/webui/www/private/scripts/dynamicTable.js Outdated Show resolved Hide resolved
@Piccirello
Copy link
Member Author

Piccirello commented Oct 24, 2024

In GUI we have "Resize columns" at the bottom of menu. It will resize all enabled columns. Maybe you would like to match webui with it?

I didn't even realize the GUI had this option. I only added it because users on mobile won't be able to double tap the column edge. For this use case, I think having these options at the top is more useful.

I like being able to resize a single column, but resizing all also seems useful. I'll add a separate "Resize all" action.

Auto resize can be triggered by:
1. Double clicking the column's resize handle (its rightmost edge)
2. The table header's context menu
@Chocobo1 Chocobo1 requested a review from a team October 27, 2024 07:03
@Chocobo1 Chocobo1 changed the title Support auto resizing table columns WebUI: Support auto resizing table columns Oct 28, 2024
@Chocobo1 Chocobo1 merged commit e0e61ff into qbittorrent:master Oct 28, 2024
14 checks passed
@Chocobo1
Copy link
Member

@Piccirello
Thank you!

@Piccirello Piccirello deleted the column-autoresize branch October 28, 2024 06:03
@costaht
Copy link

costaht commented Oct 28, 2024

Thanks you Very much Piccirello 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resize columns with double click (web)
4 participants