Removed autocorrect/autocapitalise from filepaths on WebUI #9841
Conversation
src/webui/www/private/download.html
Outdated
| @@ -21,7 +21,7 @@ <h2 class="vcenter">QBT_TR(Download Torrents from their URLs or Magnet links)QBT | |||
| <fieldset class="settings" style="border: 0; text-align: left;"> | |||
| <div class="formRow" style="margin-top: 6px;"> | |||
| <label for="savepath" class="leftLabelLarge">QBT_TR(Save files to location:)QBT_TR[CONTEXT=HttpServer]</label> | |||
| <input type="text" id="savepath" name="savepath" style="width: 16em;" /> | |||
| <input type="text" id="savepath" name="savepath" autocorrect="off" autocapitalize="none" style="width: 16em;" /> | |||
There was a problem hiding this comment.
Can you move these attributes to the file's <form> element so that they apply to all inputs? Same for upload.html.
In the future we should probably put preferences_content.html inside a form element so that we can easily cover all inputs.
There was a problem hiding this comment.
@Piccirello, apparently, the author abandoned it... What are we supposed to do?
There was a problem hiding this comment.
@Piccirello, apparently, the author abandoned it... What are we supposed to do?
I have been busy maybe this weekend I will do the changes, I am happy for anyone else to also implement them.
|
This PR seems to be forgotten... |
Yeah, I had forgotten about it, I have now done it. I did what @Piccirello wanted but it has been a long time and now there is a conflict. |
|
I don't know how to resolve the conflict easily. My best option would be to remove the commits to "preferences_content.html" and then open a new pull request for that file. |
|
@AceLewis, you should squash all your commits into one and then rebase your branch on top of current qBittorrent master (and resolve conflicts during rebase). |
As stated in #9796 the autocorrect and autocapitalise should be removed from filepath inputs, this is a larger issue for mobile devices using the WebUI.