feat(dondominio): allow any host values including wildcard

qdm12 · Jan 28, 2024 · 417a262 · 417a262
1 parent 8839db9
commit 417a262
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/docs/dondominio.md b/docs/dondominio.md
@@ -10,6 +10,7 @@
     {
       "provider": "dondominio",
       "domain": "domain.com",
+      "host": "@",
       "name": "something",
       "username": "username",
       "password": "password",
@@ -22,6 +23,7 @@
 ### Compulsory parameters
 
 - `"domain"`
+- `"host"` is the subdomain to update which can be `@`, `*` or a subdomain
 - `"name"` is the name of the service/hosting
 - `"username"`
 - `"password"`

diff --git a/internal/provider/errors/validation.go b/internal/provider/errors/validation.go
@@ -14,7 +14,6 @@ var (
 	ErrEmailNotSet            = errors.New("email is not set")
 	ErrEmailNotValid          = errors.New("email address is not valid")
 	ErrGCPProjectNotSet       = errors.New("GCP project is not set")
-	ErrHostOnlyAt             = errors.New(`host can only be "@"`)
 	ErrHostOnlySubdomain      = errors.New("host can only be a subdomain")
 	ErrHostWildcard           = errors.New(`host cannot be a "*"`)
 	ErrIPv4KeyNotSet          = errors.New("IPv4 key is not set")

diff --git a/internal/provider/providers/dondominio/provider.go b/internal/provider/providers/dondominio/provider.go
@@ -60,8 +60,6 @@ func (p *Provider) isValid() error {
 		return fmt.Errorf("%w", errors.ErrPasswordNotSet)
 	case p.name == "":
 		return fmt.Errorf("%w", errors.ErrNameNotSet)
-	case p.host != "@":
-		return fmt.Errorf("%w", errors.ErrHostOnlyAt)
 	}
 	return nil
 }