feat(provider): add support for Mikrotik routers #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
force-pushed
the
master
branch
3 times, most recently
from
0ab3d3c
to
010634d
Compare
qdm12
force-pushed
the
master
branch
2 times, most recently
from
fd15083
to
5c166a6
Compare
qdm12
force-pushed
the
master
branch
2 times, most recently
from
bed663a
to
6a6b1a8
Compare
qdm12
reviewed
Jun 15, 2024
There was a problem hiding this comment.
Hi there! I rebased your branch and improved/modified a bit. I'm also about to work into the code to remove the routeros dependency; I have a few questions:
- Why is IPv6 not allowed? I would tend to think it should work as well as IPv4 right?
- Why limit to one item in the address list? Is it not possible to handle multiple? I changed the code to handle multiple, but let me know if that's a problem.
Thanks!
|
Please try the latest code from your branch. I pushed another commit to remove the dependency on routeros (re-coding the logic needed), saving ~100KB of program size 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting up hairpin NAT on Mikrotik routers, it is much easier if you have your public IP set in an address list. This provider adds the ability to update an address list via the router's API.