Add NameSilo provider #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
reviewed
Dec 2, 2024
Co-authored-by: Quentin McGaw <quentin.mcgaw@gmail.com>
- Splits create and update logic for simplicity. - Fixes scope of internal response struct. - Compresses example images to minimise repo size.
|
I have updated the PR based on the review suggestions. |
|
NOTE: you may need to Can you add the following entry to .github/workflows/configs/mlc-config.json so the markdown links check ignores them: {
"pattern": "^https://www.namesilo.com/"
},Given the markdown CI check errors: Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for NameSilo. Resolves #313
I have tested locally and it seems to work for my domains. Wildcards and IPv6 are supported. The provider will create a new record if one does not already exist.
With credit to @Zeustopher for writing most of the readme in this comment.
The API documentation is here for reference: NameSilo API Reference.