Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to tonic 0.9 #40

Merged
merged 1 commit into from
May 3, 2023
Merged

update to tonic 0.9 #40

merged 1 commit into from
May 3, 2023

Conversation

agourlay
Copy link
Member

@agourlay agourlay commented May 2, 2023

Needs extra care to handle the breaking change around max decoding size

@agourlay agourlay requested review from coszio and timvisee May 3, 2023 09:39
@agourlay agourlay requested a review from llogiq May 3, 2023 10:03
llogiq
llogiq approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@llogiq llogiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a small nit about duplicated code.

src/client.rs Show resolved Hide resolved
@agourlay agourlay merged commit 843172c into master May 3, 2023
@agourlay agourlay deleted the tonic-0.9 branch May 3, 2023 13:34
@agourlay agourlay mentioned this pull request May 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llogiq llogiq llogiq approved these changes

@coszio coszio Awaiting requested review from coszio

@timvisee timvisee Awaiting requested review from timvisee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agourlay @llogiq