Feature/candidate baking #1307
Merged
Feature/candidate baking #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iceseer
force-pushed
the
feature/candidate_baking
branch
from
b093311 to
9d22ae2
Compare
iceseer
force-pushed
the
feature/candidate_baking
branch
from
35b21b3 to
50ed8d0
Compare
Signed-off-by: iceseer <iceseer@gmail.com>
iceseer
force-pushed
the
feature/candidate_baking
branch
from
50ed8d0 to
2169b6c
Compare
turuslan
reviewed
Aug 31, 2022
turuslan
reviewed
Aug 31, 2022
turuslan
reviewed
Aug 31, 2022
turuslan
reviewed
Aug 31, 2022
turuslan
reviewed
Aug 31, 2022
turuslan
reviewed
Aug 31, 2022
turuslan
reviewed
Aug 31, 2022
Signed-off-by: iceseer <iceseer@gmail.com>
turuslan
reviewed
Sep 1, 2022
iceseer
force-pushed
the
feature/candidate_baking
branch
from
06137e7 to
2cdaa39
Compare
Codecov Report
@@ Coverage Diff @@
## master #1307 +/- ##
==========================================
- Coverage 24.94% 24.50% -0.44%
==========================================
Files 612 612
Lines 22589 22984 +395
Branches 11794 11998 +204
==========================================
- Hits 5635 5633 -2
- Misses 11751 12149 +398
+ Partials 5203 5202 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
turuslan
previously approved these changes
Sep 5, 2022
Comment on lines
+291
to
+293
| std::shared_ptr<WorkersContext> context_; | ||
| std::shared_ptr<WorkGuard> work_guard_; | ||
| std::unique_ptr<std::thread> workers_[kBackgroundWorkers]; |
There was a problem hiding this comment.
Better to wrap as (?)ThreadPool for reuse.
ortyomka
reviewed
Sep 14, 2022
Signed-off-by: iceseer <iceseer@gmail.com>
ortyomka
approved these changes
Sep 16, 2022
turuslan
requested changes
Sep 16, 2022
| func{std::forward<F>(func)}, | ||
| stream](auto &&result) mutable { | ||
| auto self = wptr.lock(); | ||
| if (!result || !self) return std::forward<F>(func)(std::move(result)); |
There was a problem hiding this comment.
Suggested change
| if (!result || !self) return std::forward<F>(func)(std::move(result)); | |
| if (!result || !self) { | |
| return std::forward<F>(func)(std::move(result)); |
| }); | ||
| template <bool DirectionIncoming, typename F> | ||
| void doCollatorHandshake( | ||
| std::shared_ptr<kagome::network::Stream> const &stream, F &&func) { |
There was a problem hiding this comment.
Suggested change
| std::shared_ptr<kagome::network::Stream> const &stream, F &&func) { | |
| const std::shared_ptr<kagome::network::Stream> &stream, F &&func) { |
Comment on lines
+69
to
+72
| if (!stream) | ||
| cb(ProtocolError::HANDSHAKE_ERROR); | ||
| else | ||
| cb(stream); |
There was a problem hiding this comment.
Suggested change
| if (!stream) | |
| cb(ProtocolError::HANDSHAKE_ERROR); | |
| else | |
| cb(stream); | |
| if (!stream) { | |
| cb(ProtocolError::HANDSHAKE_ERROR); | |
| } else { | |
| cb(stream); | |
| } |
| doCollatorHandshake<true>( | ||
| stream, | ||
| [wptr{weak_from_this()}]( | ||
| std::shared_ptr<Stream> const &stream) mutable { |
There was a problem hiding this comment.
Suggested change
| std::shared_ptr<Stream> const &stream) mutable { | |
| const std::shared_ptr<Stream> &stream) mutable { |
| @@ -305,6 +304,7 @@ namespace kagome::network { | |||
| } | |||
|
|
|||
| ProtocolBaseImpl base_; | |||
| Protocol const protocol_; | |||
There was a problem hiding this comment.
Suggested change
| Protocol const protocol_; | |
| const Protocol protocol_; |
Comment on lines
+122
to
+127
| auto const &[it, inserted] = peer_map.insert( | ||
| std::make_pair(peer_id, | ||
| std::make_shared<FetchedCollationState>( | ||
| std::move(response), | ||
| CollationState::kFetched, | ||
| PoVDataState::kComplete))); |
There was a problem hiding this comment.
Suggested change
| auto const &[it, inserted] = peer_map.insert( | |
| std::make_pair(peer_id, | |
| std::make_shared<FetchedCollationState>( | |
| std::move(response), | |
| CollationState::kFetched, | |
| PoVDataState::kComplete))); | |
| auto inserted = peer_map.emplace( | |
| peer_id, | |
| std::make_shared<FetchedCollationState>( | |
| std::move(response), | |
| CollationState::kFetched, | |
| PoVDataState::kComplete)).second; |
Comment on lines
+244
to
+255
| outcome::result<network::Signature> ParachainProcessorImpl::sign( | ||
| T const &t) const { | ||
| if (!keypair_) return Error::KEY_NOT_PRESENT; | ||
|
|
||
| auto payload = scale::encode(t).value(); | ||
| return crypto_provider_->sign(*keypair_, payload).value(); | ||
| } | ||
|
|
||
| std::optional<network::ValidatorIndex> ParachainProcessorImpl::getOurIndex() { | ||
| logger_->error("Not implemented. Return my validator index."); | ||
| return std::nullopt; | ||
| } |
There was a problem hiding this comment.
May use ValidatorSigner from #1336 (TODO: signable trait or conversion function, e.g. bitfield is encoded as is, but statement has prefix and conversion to other type)
| candidateDescriptorFrom(*validation_result.fetched_collation), | ||
| .commitments = std::move(*validation_result.commitments)}; | ||
|
|
||
| auto sign_result = sign(receipt); |
There was a problem hiding this comment.
Must sign ("BKNG": [u8; 4], 1: u8, candidate_hash: [u8; 32])
CompactStatementInner
| } else if constexpr (kStatementType == StatementType::kValid) { | ||
| auto const candidate_hash = | ||
| candidateHashFrom(*validation_result.fetched_collation); | ||
| auto sign_result = sign(candidate_hash); |
There was a problem hiding this comment.
Must sign ("BKNG": [u8; 4], 2: u8, candidate_hash: [u8; 32])
turuslan
approved these changes
Sep 16, 2022
Signed-off-by: iceseer <iceseer@gmail.com>
iceseer
force-pushed
the
feature/candidate_baking
branch
from
b7a7f26 to
9552195
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Resolves #1289
Description of the Change
Candidate baking implementation for parachains.