Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scheduled Changes behaviour #1317

Merged
merged 5 commits into from
Oct 6, 2022
Merged

Fix Scheduled Changes behaviour #1317

merged 5 commits into from
Oct 6, 2022

Conversation

ortyomka
Copy link
Contributor

Signed-off-by: ortyomka iurin.art@gmail.com

Referenced issues

#1269

Description of the Change

Add check for overlapping scheduled changes
Fix Set ID numeration (now we assume, that second planned will based on activated previous, so we activate it)

Benefits

Correct work of Authority Manager

Possible Drawbacks

Lookup past authority set, ignore force changes. Maybe it's wrong

Signed-off-by: ortyomka <iurin.art@gmail.com>
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #1317 (2609e79) into master (0041a0b) will increase coverage by 0.03%.
The diff coverage is 38.09%.

@@            Coverage Diff             @@
##           master    #1317      +/-   ##
==========================================
+ Coverage   24.16%   24.19%   +0.03%     
==========================================
  Files         627      627              
  Lines       23421    23440      +19     
  Branches    12245    12258      +13     
==========================================
+ Hits         5660     5672      +12     
+ Misses      12492    12487       -5     
- Partials     5269     5281      +12     
Impacted Files Coverage Δ
...onsensus/authority/impl/authority_manager_impl.cpp 21.73% <38.09%> (+0.87%) ⬆️
core/api/transport/impl/ws/ws_listener_impl.cpp 40.27% <0.00%> (-2.78%) ⬇️
core/metrics/impl/prometheus/handler_impl.cpp 28.57% <0.00%> (+2.04%) ⬆️
core/consensus/authority/impl/schedule_node.cpp 69.44% <0.00%> (+2.77%) ⬆️
core/metrics/impl/session_impl.cpp 45.83% <0.00%> (+8.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kamilsa kamilsa enabled auto-merge (squash) October 5, 2022 11:26
@kamilsa kamilsa merged commit 4b6fcb6 into master Oct 6, 2022
@kamilsa kamilsa deleted the fix/set-id branch October 6, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants