Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graceful close duplicate incoming notification stream #1350

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

turuslan
Copy link
Contributor

Referenced issues

Description of the Change

Sometimes polkadot duplicates streams.
Graceful close incoming streams instead of reset (which interrupts reading).

Benefits

Don't miss incoming messages.

Possible Drawbacks

Usage Examples or Tests

Alternate Designs

Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested review from kamilsa and xDimon September 22, 2022 11:23
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #1350 (2dd6dbe) into master (60e9e2d) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #1350   +/-   ##
=======================================
  Coverage   24.39%   24.39%           
=======================================
  Files         619      619           
  Lines       23036    23038    +2     
  Branches    12019    12021    +2     
=======================================
+ Hits         5619     5621    +2     
+ Misses      12229    12228    -1     
- Partials     5188     5189    +1     
Impacted Files Coverage Δ
core/network/impl/stream_engine.hpp 23.26% <0.00%> (-0.24%) ⬇️
core/api/transport/impl/ws/ws_listener_impl.cpp 43.05% <0.00%> (+2.77%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@turuslan turuslan merged commit 610d964 into master Sep 23, 2022
@turuslan turuslan deleted the fix/duplicate-incoming branch September 23, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants