-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stream read buffer #1353
Merged
Merged
stream read buffer #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1353 +/- ##
==========================================
- Coverage 24.24% 24.15% -0.10%
==========================================
Files 622 624 +2
Lines 23235 23327 +92
Branches 12143 12179 +36
==========================================
Hits 5634 5634
- Misses 12384 12476 +92
Partials 5217 5217
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
igor-egorov
approved these changes
Sep 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to have the fix in libp2p project
Harrm
reviewed
Sep 29, 2022
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Harrm
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
Benefits
Possible Drawbacks