Parachains. PeerView implementation. #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iceseer <iceseer@gmail.com> # Conflicts: # core/blockchain/impl/block_tree_impl.cpp # core/injector/application_injector.cpp
iceseer
changed the title
iceseer
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1397 +/- ##
==========================================
- Coverage 24.47% 24.43% -0.04%
==========================================
Files 638 641 +3
Lines 24085 24148 +63
Branches 12492 12520 +28
==========================================
+ Hits 5895 5901 +6
- Misses 12928 12981 +53
- Partials 5262 5266 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
turuslan
approved these changes
Nov 8, 2022
| } | ||
| } | ||
|
|
||
| void PeerView::updateRemoteView(const PeerId &peer_id, network::View &&view) { |
There was a problem hiding this comment.
Should it sort like updateMyView?
There was a problem hiding this comment.
По спеке сказано, что эти данные должны быть отсортированы уже. Полагаю, наличие/отсутствие сортировки влияет на понижение рейтинга. Т.е. либо они отсортированы и мы с ними работаем, либо скипаем.
core/network/impl/peer_view.cpp
Outdated
| self->updateMyView( | ||
| View{.heads_ = self->block_tree_->getLeaves(), | ||
| .finalized_number_ = | ||
| self->block_tree_->getLastFinalized().number}); |
There was a problem hiding this comment.
Suggested change
| self->block_tree_->getLastFinalized().number}); | |
| self->block_tree_->getLastFinalized().number, | |
| }); |
xDimon
reviewed
Nov 16, 2022
core/network/impl/peer_view.cpp
Outdated
| self->updateMyView( | ||
| View{.heads_ = self->block_tree_->getLeaves(), | ||
| .finalized_number_ = | ||
| self->block_tree_->getLastFinalized().number}); |
iceseer
force-pushed
the
feature/peer_view_impl
branch
2 times, most recently
from
a8b35b0 to
c12b4bd
Compare
Signed-off-by: iceseer <iceseer@gmail.com>
iceseer
force-pushed
the
feature/peer_view_impl
branch
from
c12b4bd to
3042256
Compare
xDimon
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: iceseer iceseer@gmail.com