Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parachains. Transcript chellenge bytes #1399

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

iceseer
Copy link
Contributor

@iceseer iceseer commented Nov 8, 2022

  1. Added Transcript::challenge_bytes.

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #1399 (1f5948a) into master (d4505e2) will increase coverage by 0.13%.
The diff coverage is 6.86%.

❗ Current head 1f5948a differs from pull request most recent head bcd9218. Consider uploading reports for the commit bcd9218 to get more accurate results

@@            Coverage Diff             @@
##           master    #1399      +/-   ##
==========================================
+ Coverage   24.33%   24.46%   +0.13%     
==========================================
  Files         643      633      -10     
  Lines       24252    23723     -529     
  Branches    12573    12344     -229     
==========================================
- Hits         5901     5805      -96     
+ Misses      13085    12641     -444     
- Partials     5266     5277      +11     
Impacted Files Coverage Δ
core/blockchain/impl/block_tree_impl.hpp 33.33% <ø> (-66.67%) ⬇️
core/common/visitor.hpp 58.33% <0.00%> (ø)
core/injector/application_injector.cpp 32.32% <0.00%> (-7.47%) ⬇️
core/network/impl/peer_view.cpp 0.00% <0.00%> (-3.64%) ⬇️
core/network/peer_view.hpp 0.00% <0.00%> (-100.00%) ⬇️
core/network/types/collator_messages.hpp 0.00% <0.00%> (ø)
core/parachain/thread_pool.hpp 0.00% <0.00%> (ø)
core/primitives/math.hpp 100.00% <ø> (ø)
core/blockchain/impl/block_tree_impl.cpp 21.47% <50.00%> (+1.67%) ⬆️
core/primitives/transcript.hpp 72.72% <100.00%> (ø)
... and 117 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: iceseer <iceseer@gmail.com>

# Conflicts:
#	core/blockchain/impl/block_tree_impl.cpp
#	core/injector/application_injector.cpp
#	core/network/impl/peer_view.cpp
#	core/network/peer_view.hpp
@iceseer iceseer force-pushed the feature/transcript_chellenge_bytes branch from 4a7f53c to bcd9218 Compare November 22, 2022 06:01
@iceseer iceseer requested review from Harrm and xDimon November 22, 2022 06:02
@iceseer iceseer merged commit a635da3 into master Nov 22, 2022
@iceseer iceseer deleted the feature/transcript_chellenge_bytes branch November 22, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants