Feature: authority manager checkpoints #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: authority namespace renamed to consensus::grandpa refactor: authority code moved to grandpa Signed-off-by: safinsaf <safinsaft@gmail.com>
Signed-off-by: safinsaf <safinsaft@gmail.com>
refactor: receive digest by auth manager over digest tracker Signed-off-by: safinsaf <safinsaft@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
xDimon
force-pushed
the
feature/authmngr_checkpoints
branch
from
b85aee6 to
2c7bd8b
Compare
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Harrm
reviewed
Nov 22, 2022
kamilsa
reviewed
Nov 22, 2022
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
kamilsa
approved these changes
Nov 25, 2022
Harrm
reviewed
Nov 25, 2022
| const auto &header = context.header.value().get(); | ||
| block.emplace(header.number - 1, header.parent_hash); | ||
| } else { | ||
| block.emplace(context.block); |
There was a problem hiding this comment.
Under what circumstances does this occur?
There was a problem hiding this comment.
When block is not in a tree, we should use parent block to check direct chain existing. In other case (block is already in tree) we can use block info of block for that (ex. while digests reapplying at start).
There was a problem hiding this comment.
So when context.header has value that means the block is not in the tree?
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Harrm
reviewed
Nov 25, 2022
| const auto &header = context.header.value().get(); | ||
| block.emplace(header.number - 1, header.parent_hash); | ||
| } else { | ||
| block.emplace(context.block); |
There was a problem hiding this comment.
So when context.header has value that means the block is not in the tree?
Harrm
reviewed
Nov 25, 2022
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
CrimeaTop
approved these changes
Nov 25, 2022
Harrm
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Resolves #1396
Description of the Change
All content of authority namespace was moved to consensus::grandpa.
Implemented formatter for outcome to use them directly:
SL_DEBUG(log, "Error: {}", res.error());(without.message()).AuthorityManager switched to process digests over DigestTracker.
Implemented mechanism of checkpoints in AuthorityManager.
Fixed applying of postponed justification.
Fixed making on new grandpa round.
Removed outdated mechanism of recovery AuthorityManager state.
Fixed procession of commit message in grandpa.
Many improvements of logging with various parts of project.
Babe things moved to consensus::babe namespace.
Import was replaced by forward declarations (only in /core/consensus directory).
Benefits
Stable working.
Fast recovery.
Usage Examples or Tests
Adapted