Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log with best and finalized blocks on launch #1414

Merged
merged 3 commits into from
Dec 9, 2022

Conversation

Harrm
Copy link
Contributor

@Harrm Harrm commented Nov 18, 2022

Referenced issues

None.

Description of the Change

Self-descriptive.

Benefits

For example, it's easy to know what block to run recovery on when node initialisation fails.

Possible Drawbacks

None expected.

@Harrm Harrm self-assigned this Nov 18, 2022
@Harrm Harrm marked this pull request as ready for review November 18, 2022 11:53
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #1414 (913159e) into master (2b6d360) will increase coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 913159e differs from pull request most recent head c6edf22. Consider uploading reports for the commit c6edf22 to get more accurate results

@@            Coverage Diff             @@
##           master    #1414      +/-   ##
==========================================
+ Coverage   24.31%   24.33%   +0.01%     
==========================================
  Files         643      643              
  Lines       24260    24252       -8     
  Branches    12577    12574       -3     
==========================================
+ Hits         5899     5901       +2     
+ Misses      13096    13083      -13     
- Partials     5265     5268       +3     
Impacted Files Coverage Δ
core/blockchain/impl/block_tree_impl.cpp 19.77% <0.00%> (-0.04%) ⬇️
core/subscription/subscriber.hpp 62.22% <0.00%> (-0.83%) ⬇️
node/main.cpp 0.00% <0.00%> (ø)
core/primitives/transcript.hpp 72.72% <0.00%> (ø)
core/utils/kagome_db_editor.cpp 0.00% <0.00%> (ø)
core/network/impl/peer_manager_impl.cpp 3.26% <0.00%> (+<0.01%) ⬆️
core/api/service/impl/api_service_impl.cpp 14.47% <0.00%> (+1.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Harrm Harrm merged commit 4c99945 into master Dec 9, 2022
@Harrm Harrm deleted the feature/log-best-and-finalized branch December 9, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants