Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor storage interface #1435

Merged
merged 20 commits into from
Dec 6, 2022
Merged

Refactor storage interface #1435

merged 20 commits into from
Dec 6, 2022

Conversation

turuslan
Copy link
Contributor

@turuslan turuslan commented Dec 4, 2022

Referenced issues

Description of the Change

  • Add BufferOrView, like rust Cow
    • Move only.
    • Construct from buffer view, or from moved buffer.
    • mut and into like rust.
  • Deduplicate storage interface read returning either buffer or view.
  • Deduplicate storage interface write accepting buffer or view.
  • Merge storage interfaces and inherit implementations from single one.

Benefits

  • Deduplicate code
  • Simplify ambiguous interface

Possible Drawbacks

turuslan added 16 commits December 4, 2022 06:21
@turuslan
BufferOrView
cee33a9 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
put
e52791a 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
equality
7a43959 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
load
47365c7 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
use alias
0b432bf 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
cursor value
ad06b83 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
get
152e3db 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
equality
a2c284f 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
moved
4557590 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
rename trait
ea3d9e7 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
load -> get
21fc636 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
remove alias
6753f63 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
remove unused
4dda6b9 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
merge readable
2d7b8e1 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
view
eed002a 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
merge interfaces
a4bd20d 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
turuslan and others added 2 commits December 6, 2022 11:53
@turuslan
Merge branch 'master' into refactor/buffer-or-view
58fe46a
@turuslan
boost variant
e5aa896 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
xDimon
xDimon requested changes Dec 6, 2022
View reviewed changes
core/common/buffer_or_view.hpp Outdated Show resolved Hide resolved
core/common/buffer_or_view.hpp Show resolved Hide resolved
core/common/buffer_or_view.hpp Outdated Show resolved Hide resolved
core/storage/face/batch_writeable.hpp Outdated Show resolved Hide resolved
@turuslan
throw
ce6b6a7 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
comments
af0ab85 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested a review from xDimon December 6, 2022 10:04
xDimon
xDimon approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@xDimon xDimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@turuslan turuslan enabled auto-merge (squash) December 6, 2022 10:11
@turuslan turuslan merged commit 96bd48b into master Dec 6, 2022
@turuslan turuslan deleted the refactor/buffer-or-view branch December 6, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDimon xDimon xDimon approved these changes

@igor-egorov igor-egorov igor-egorov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turuslan @xDimon @igor-egorov