Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix external project #1442

Merged
merged 7 commits into from
Dec 9, 2022
Merged

Fix external project #1442

merged 7 commits into from
Dec 9, 2022

Conversation

CrimeaTop
Copy link
Contributor

@CrimeaTop CrimeaTop commented Dec 6, 2022

Referenced issues

resolves #1438

Description of the Change

Hunter has a buggy FindRapidJSON.cmake file, we avoid using it by specifying in kagome installation config that we want to use RapidJSONConfig.cmake instead.

Benefits

  • Kagome works as an external project without additional crutches.

Possible Drawbacks

  • None expected.

@CrimeaTop CrimeaTop marked this pull request as ready for review December 7, 2022 11:34
@Harrm Harrm requested a review from iceseer December 7, 2022 11:35
@Harrm Harrm merged commit 12805ce into master Dec 9, 2022
@Harrm Harrm deleted the fix/external-project branch December 9, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix external project build step
4 participants