Add storage spaces support #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turuslan
approved these changes
Dec 15, 2022
added 5 commits
January 16, 2023 00:19
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
igor-egorov
force-pushed
the
spaced-storage
branch
from
f4f2aef to
a6b3a19
Compare
added 2 commits
January 20, 2023 04:22
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
igor-egorov
force-pushed
the
spaced-storage
branch
from
19c8d1e to
32275ed
Compare
added 3 commits
January 25, 2023 12:41
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
igor-egorov
force-pushed
the
spaced-storage
branch
from
32275ed to
dae7eac
Compare
added 3 commits
January 25, 2023 15:37
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
turuslan
approved these changes
Jan 25, 2023
added 3 commits
January 25, 2023 17:37
Kagome db editor is not operable at the moment. It will be fixed as part of aggressive pruning task Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
kamilsa
reviewed
Jan 26, 2023
| block_number, | ||
| block_data.hash, | ||
| Buffer{encoded_block_data})); | ||
| OUTCOME_TRY(putToSpace(*storage_, |
There was a problem hiding this comment.
Am I right. We are putting block data into a separate space. However we can also be putting header into a 'headers' space. Therefore, if block data contains header we may store the same block header twice?
There was a problem hiding this comment.
The fields are kept for binary consistency and are not to be used
added 2 commits
January 26, 2023 10:16
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
kamilsa
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Igor Egorov igor@soramitsu.co.jp
Referenced issues
Resolves to #1312
Description of the Change
Use spaced storage engine
Benefits
Ease of operating over the storage