Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallel GRANDPA #1517

Merged
merged 14 commits into from
May 2, 2023
Merged

Parallel GRANDPA #1517

merged 14 commits into from
May 2, 2023

Conversation

iceseer
Copy link
Contributor

@iceseer iceseer commented Mar 10, 2023 •
edited
Loading

Description of the Change

  1. GRANDPA moved to separate thread
  2. Block Tree become thread-safe
  3. Grandpa context become simple structure.
  4. JustifiactionStoragePolicy doesn't depend on block_tree.
  5. minor changes

@iceseer iceseer force-pushed the feature/parallel_grandpa branch from 04086a2 to 844693e Compare March 12, 2023 12:47
@iceseer iceseer marked this pull request as ready for review March 16, 2023 06:55
@igor-egorov igor-egorov self-requested a review March 21, 2023 07:42
@iceseer iceseer force-pushed the feature/parallel_grandpa branch from 33319a8 to a9619d8 Compare March 24, 2023 07:14
@iceseer iceseer requested review from turuslan and xDimon March 24, 2023 07:14
@iceseer iceseer force-pushed the feature/parallel_grandpa branch from a9619d8 to e2c04ba Compare March 24, 2023 07:16
turuslan
turuslan reviewed Mar 27, 2023
View reviewed changes
core/consensus/grandpa/grandpa_context.hpp Outdated Show resolved Hide resolved
core/utils/thread_pool.hpp Outdated Show resolved Hide resolved
core/utils/thread_pool.hpp Outdated Show resolved Hide resolved
xDimon
xDimon reviewed Apr 13, 2023
View reviewed changes
core/blockchain/impl/block_tree_impl.hpp Show resolved Hide resolved
core/consensus/babe/impl/block_appender_base.cpp Show resolved Hide resolved
core/consensus/babe/impl/block_appender_base.cpp Show resolved Hide resolved
core/consensus/babe/impl/block_executor_impl.cpp Show resolved Hide resolved
core/consensus/babe/impl/block_header_appender_impl.cpp Show resolved Hide resolved
core/injector/application_injector.cpp Outdated Show resolved Hide resolved
test/core/consensus/babe/block_executor_test.cpp Outdated Show resolved Hide resolved
test/mock/core/consensus/grandpa/environment_mock.hpp Outdated Show resolved Hide resolved
test/mock/core/consensus/grandpa/grandpa_mock.hpp Outdated Show resolved Hide resolved
test/mock/core/consensus/grandpa/voting_round_mock.hpp Outdated Show resolved Hide resolved
@iceseer
parallel GRANDPA
616c457 
Signed-off-by: iceseer <iceseer@gmail.com>
@iceseer iceseer force-pushed the feature/parallel_grandpa branch from 64176e3 to 616c457 Compare April 23, 2023 14:06
@iceseer
formatting
b1843f9 
Signed-off-by: iceseer <iceseer@gmail.com>
@iceseer iceseer requested review from xDimon and turuslan April 23, 2023 14:09
iceseer added 4 commits April 24, 2023 12:15
@iceseer
build fixup
414dbbf 
Signed-off-by: iceseer <iceseer@gmail.com>
@iceseer
Merge remote-tracking branch 'origin/master' into feature/parallel_gr…
cf7275a 
…andpa

Signed-off-by: iceseer <iceseer@gmail.com>

# Conflicts:
#	core/blockchain/impl/block_tree_impl.cpp
#	core/consensus/grandpa/impl/grandpa_impl.cpp
#	core/consensus/grandpa/justification_observer.hpp
#	core/injector/application_injector.cpp
@iceseer
fixup
5998eb5 
Signed-off-by: iceseer <iceseer@gmail.com>
@iceseer
formatted
3188873 
Signed-off-by: iceseer <iceseer@gmail.com>
turuslan
turuslan requested changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@turuslan turuslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warp sync loop

@iceseer
fixup
80ffd0f 
Signed-off-by: iceseer <iceseer@gmail.com>
@igor-egorov igor-egorov removed their request for review April 28, 2023 08:33
iceseer added 3 commits April 30, 2023 14:24
@iceseer
do send from main thread
d4c3099 
Signed-off-by: iceseer <iceseer@gmail.com>
@iceseer
justification verification fixup
467a64a 
Signed-off-by: iceseer <iceseer@gmail.com>
@iceseer
formatting
a5f5ed4 
Signed-off-by: iceseer <iceseer@gmail.com>
@iceseer
verification result moved to promise/future (callback removed)
4772708 
Signed-off-by: iceseer <iceseer@gmail.com>
iceseer added 3 commits April 30, 2023 16:54
@iceseer
fixup
26b3e7f 
Signed-off-by: iceseer <iceseer@gmail.com>
@iceseer
tests
89ad339 
Signed-off-by: iceseer <iceseer@gmail.com>
@iceseer
formatting
40e8ae1 
Signed-off-by: iceseer <iceseer@gmail.com>
@iceseer iceseer enabled auto-merge (squash) May 2, 2023 07:30
@iceseer iceseer merged commit d4c3ac9 into master May 2, 2023
@iceseer iceseer deleted the feature/parallel_grandpa branch May 2, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDimon xDimon xDimon approved these changes

@turuslan turuslan turuslan approved these changes

Assignees

@iceseer iceseer

Labels
Multithreading Networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iceseer @xDimon @turuslan @kamilsa