Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow unsafe rpc #1573

Merged
merged 9 commits into from
May 2, 2023
Merged

allow unsafe rpc #1573

merged 9 commits into from
May 2, 2023

Conversation

turuslan
Copy link
Contributor

Referenced issues

Description of the Change

  • allow_unsafe for api listener and session
  • --rpc-methods
  • add zombienet flags

Benefits

  • accept zombienet flags

Possible Drawbacks

@turuslan
flags, allow unsafe rpc
5d0582d 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@kamilsa kamilsa requested review from iceseer and Harrm April 21, 2023 08:46
iceseer
iceseer approved these changes Apr 26, 2023
View reviewed changes
core/api/allow_unsafe.hpp Outdated Show resolved Hide resolved
Harrm
Harrm reviewed Apr 26, 2023
View reviewed changes
core/api/jrpc/jrpc_server.hpp Show resolved Hide resolved
core/api/transport/impl/http/http_session.cpp Outdated Show resolved Hide resolved
core/application/impl/app_configuration_impl.cpp Outdated Show resolved Hide resolved
turuslan added 6 commits April 27, 2023 07:19
@turuslan
pr comment
76a23ba 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
Merge remote-tracking branch 'origin/master' into cli/rpc
7b8544f
@turuslan
pr comment
b902689 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
fix
d93ebfc 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
pr comment (enum)
0559932 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
pr comment
6ab3ac1 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested a review from Harrm April 27, 2023 04:58
@turuslan turuslan enabled auto-merge (squash) May 2, 2023 10:11
@turuslan turuslan merged commit 1f75bc0 into master May 2, 2023
@turuslan turuslan deleted the cli/rpc branch May 2, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iceseer iceseer iceseer approved these changes

@Harrm Harrm Harrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turuslan @Harrm @iceseer