limit offchain threads #1630
Merged
limit offchain threads #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
xDimon
approved these changes
May 24, 2023
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
iceseer
reviewed
May 29, 2023
| using Task = std::function<void()>; | ||
|
|
||
| Runner(size_t threads, size_t max_tasks) | ||
| : threads_{threads}, |
There was a problem hiding this comment.
мне кажется не стоит тут порождать потоки, у нас уже создается пулл для фоновых задач и можно выполнять в нем https://imgur.com/7zEUjSI.png
А в пулле нам по сути без разницы на какую работу тратится время пулла, от этого ресурсов больше не станет, так что счетчик max_tasks будет нормально работать.
Зато в дальнейшем это даст например возможность ограничить этим же кодом некоторые задачи в парачейнах.
iceseer
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
Benefits
Possible Drawbacks