produce and execute blocks on thread pool #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xDimon
requested changes
Jun 5, 2023
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
turuslan
force-pushed
the
thread/block-wasm
branch
from
411f326 to
68c0bd9
Compare
Signed-off-by: turuslan <turuslan.devbox@gmail.com> # Conflicts: # core/consensus/babe/impl/babe_impl.cpp # core/consensus/babe/impl/block_executor_impl.cpp # test/core/consensus/babe/block_executor_test.cpp
xDimon
approved these changes
Sep 6, 2023
Harrm
reviewed
Sep 13, 2023
| @@ -186,6 +199,19 @@ namespace kagome::consensus::babe { | |||
| clock::SystemClock::TimePoint slot_timestamp, | |||
| std::optional<std::reference_wrapper<const crypto::VRFOutput>> output, | |||
| primitives::AuthorityIndex authority_index); | |||
| /** | |||
| * `processSlotLeadership` coroutine piece | |||
There was a problem hiding this comment.
This can be confusing because it's not actually a coroutine, I'd rather that you describe it in the comment the way it is.
Harrm
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
Benefits
Possible Drawbacks