-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gbd and gdbserver to images #1717
Conversation
Signed-off-by: safinsaf <safinsaft@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1717 +/- ##
==========================================
+ Coverage 21.57% 21.96% +0.38%
==========================================
Files 751 748 -3
Lines 32259 32285 +26
Branches 16746 16627 -119
==========================================
+ Hits 6961 7091 +130
+ Misses 19486 19360 -126
- Partials 5812 5834 +22 see 203 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: safinsaf <safinsaft@gmail.com>
Signed-off-by: safinsaf <safinsaft@gmail.com>
Signed-off-by: safinsaf <safinsaft@gmail.com>
Signed-off-by: safinsaf <safinsaft@gmail.com>
Signed-off-by: safinsaf <safinsaft@gmail.com>
Signed-off-by: safinsaf <safinsaft@gmail.com>
Signed-off-by: safinsaf <safinsaft@gmail.com>
Signed-off-by: safinsaf <safinsaft@gmail.com>
Signed-off-by: safinsaf <safinsaft@gmail.com>
Signed-off-by: safinsaf <safinsaft@gmail.com>
Signed-off-by: safinsaf <safinsaft@gmail.com>
Signed-off-by: safinsaf <safinsaft@gmail.com>
Signed-off-by: safinsaf <safinsaft@gmail.com>
Signed-off-by: safinsaf <safinsaft@gmail.com>
This reverts commit 24ac6e7.
Signed-off-by: safinsaf <safinsaft@gmail.com>
Signed-off-by: safinsaf <safinsaft@gmail.com>
Signed-off-by: safinsaf <safinsaft@gmail.com>
Signed-off-by: safinsaf <safinsaft@gmail.com>
Signed-off-by: safinsaf <safinsaft@gmail.com>
Signed-off-by: safinsaf <safinsaft@gmail.com>
Signed-off-by: safinsaf <safinsaft@gmail.com>
Signed-off-by: safinsaf <safinsaft@gmail.com>
Signed-off-by: safinsaf <safinsaft@gmail.com>
Signed-off-by: safinsaf <safinsaft@gmail.com>
Signed-off-by: safinsaf <safinsaft@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When in this new kagome-dev image we are building new hunter dependencies they cannot be uploaded to hunter-binary-cache with error:
...
[100%] Completed 'backward-cpp-Debug'
[100%] Built target backward-cpp-Debug
-- [hunter] Build step successful (dir: /root/.hunter/_Base/0a8363a/27ad7ef/cfa8f6c/Build/backward-cpp)
-- [hunter] Cache saved: /root/.hunter/_Base/Cache/raw/de0e9ec254c053390556cb4a16d5870e18223b5a.tar.bz2
Traceback (most recent call last):
File "/root/.hunter/_Base/Download/Hunter/0.23.257-soramitsu58/0a8363a/Unpacked/scripts/upload-cache-to-github.py", line 8, in <module>
import requests
ModuleNotFoundError: No module named 'requests'
[hunter ** INTERNAL **] Upload script failed
[hunter ** INTERNAL **] [Directory:/kagome/cmake]
Need to activate /venv (discussed and tested locally, all works) |
Referenced issues
https://soramitsu.atlassian.net/jira/software/c/projects/DOPS/boards/43?modal=detail&selectedIssue=DOPS-2654&assignee=6163c8b178e5e40070bcd5f7
Description of the Change
Update base image for kagome-dev
Add gdb and gdb server to images
Remove gcc 10, use gcc 11 in CI instead
Apply new pip politics of safe directories and enforced venv
Benefits
Possible Drawbacks
Usage Examples or Tests
Alternate Designs