Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broadcast neighbor #1735

Merged
merged 6 commits into from
Aug 18, 2023
Merged

broadcast neighbor #1735

merged 6 commits into from
Aug 18, 2023

Conversation

turuslan
Copy link
Contributor

Referenced issues

Description of the Change

  • don't send duplicate
  • don't send to light client if set didn't change

Benefits

Possible Drawbacks

kamilsa
kamilsa approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@kamilsa kamilsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we start lagging less by finalization with smaller amount of peers after this PR

@kamilsa kamilsa requested a review from xDimon August 16, 2023 07:28
@turuslan turuslan merged commit 8534ed5 into master Aug 18, 2023
@turuslan turuslan deleted the broadcast/neighbor branch August 18, 2023 07:52
@turuslan turuslan mentioned this pull request Aug 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDimon xDimon xDimon approved these changes

@kamilsa kamilsa kamilsa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turuslan @xDimon @kamilsa