Disable failing MetadataTest due to LRU cache issue #1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit disables the MetadataTest in test/core/runtime/binaryen/metadata_test.cpp. The test was failing due to an issue with LRU cache as noted in issue #1775. The test will be enabled back once this issue is fixed.
Harrm
approved these changes
Aug 31, 2023
xDimon
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit disables the MetadataTest in test/core/runtime/binaryen/metadata_test.cpp. The test was failing due to an issue with LRU cache as noted in issue #1775. The test will be enabled back once this issue is fixed.
Referenced issues
Relates to #1775
Description of the Change
Disable failing test, we should enable it back when #1775 is fixed
Benefits
No crashing tests
Possible Drawbacks
None