Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deduplicate notifications code #1806

Merged
merged 3 commits into from
Sep 28, 2023
Merged

deduplicate notifications code #1806

merged 3 commits into from
Sep 28, 2023

Conversation

turuslan
Copy link
Contributor

Referenced issues

Description of the Change

  • StreamEngine::add returns void
  • deduplicate readHandshake/writeHandshake/read to handshakeAndReadMessages/connectAndHandshake
  • remove unused

Benefits

Possible Drawbacks

  • may deduplicate logs too

@turuslan
simplify
df23ee1 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested review from xDimon and iceseer September 13, 2023 13:02
@turuslan turuslan mentioned this pull request Sep 25, 2023
Merged
@turuslan
revert
cb9deff 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan merged commit 143d385 into master Sep 28, 2023
@turuslan turuslan deleted the refactor/notifications branch September 28, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iceseer iceseer iceseer approved these changes

@xDimon xDimon xDimon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turuslan @xDimon @iceseer