Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check wrong set #1929

Merged
merged 1 commit into from
Jan 15, 2024
Merged

check wrong set #1929

merged 1 commit into from
Jan 15, 2024

Conversation

turuslan
Copy link
Contributor

Referenced issues

Description of the Change

  • check wrong set, assuming VotingRoundImpl::doFinalize calls finalize with wrong justification

Benefits

Possible Drawbacks

@turuslan
check wrong set
218f89a 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested review from xDimon and kamilsa January 15, 2024 07:37
@turuslan turuslan merged commit bdcc593 into master Jan 15, 2024
13 checks passed
@turuslan turuslan deleted the grandpa/check-wrong-set branch January 15, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDimon xDimon xDimon approved these changes

@kamilsa kamilsa kamilsa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turuslan @xDimon @kamilsa