Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor #1934

Merged
merged 3 commits into from
Jan 18, 2024
Merged

refactor #1934

merged 3 commits into from
Jan 18, 2024

Conversation

turuslan
Copy link
Contributor

Referenced issues

Description of the Change

  • remove Synchronizer callback from GrandpaImpl
    • watch good blocks from chain subscription
    • unwatch messages for removed rounds
  • Timeline.wasSynchronized()
  • retain(vec, f)

Benefits

Possible Drawbacks

@turuslan
refactor
8d9d40f 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested a review from xDimon January 17, 2024 10:38
@igor-egorov igor-egorov self-requested a review January 17, 2024 10:57
igor-egorov
igor-egorov approved these changes Jan 17, 2024
View reviewed changes
core/common/lru_cache.hpp Show resolved Hide resolved
kamilsa
kamilsa reviewed Jan 17, 2024
View reviewed changes
core/utils/retain.hpp Outdated Show resolved Hide resolved
@turuslan turuslan requested a review from kamilsa January 17, 2024 14:38
@turuslan turuslan merged commit ae83d83 into master Jan 18, 2024
12 of 13 checks passed
@turuslan turuslan deleted the refactor/2 branch January 18, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilsa kamilsa kamilsa approved these changes

@igor-egorov igor-egorov igor-egorov approved these changes

@xDimon xDimon Awaiting requested review from xDimon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turuslan @kamilsa @igor-egorov